linux-kernel - Re: [PATCH] IPC: fix put_compat_shm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170927004918.j5tgulqial4f67zh@yury-thinkpad>
Date:   Wed, 27 Sep 2017 03:49:18 +0300
From:   Yury Norov <ynorov@...iumnetworks.com>
To:     Andrew Morton <akpm@...ux-foundation.org>,
        Al Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] IPC: fix put_compat_shm_info()

On Wed, Sep 27, 2017 at 03:32:54AM +0300, Yury Norov wrote:
> There's a typo in put_compat_shm_info() - the first argument
> of copy_to_user() is 'up' instead of 'uip'. And 'up' is
> occasionly a suitable variable name so the compiler doesn't
> complain.
> 
> Signed-off-by: Yury Norov <ynorov@...iumnetworks.com>

Ah, I just pulled latest sources and found it already fixed.
Please forget.

> ---
>  ipc/shm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ipc/shm.c b/ipc/shm.c
> index 1e2b1692ba2c..badac463e2c8 100644
> --- a/ipc/shm.c
> +++ b/ipc/shm.c
> @@ -1154,7 +1154,7 @@ static int put_compat_shm_info(struct shm_info *ip,
>  	info.shm_swp = ip->shm_swp;
>  	info.swap_attempts = ip->swap_attempts;
>  	info.swap_successes = ip->swap_successes;
> -	return copy_to_user(up, &info, sizeof(info));
> +	return copy_to_user(uip, &info, sizeof(info));
>  }
>  
>  static int copy_compat_shmid_to_user(void __user *buf, struct shmid64_ds *in,
> -- 
> 2.11.0