linux-kernel - RE: Re: [PATCH v2 0/8] PM / devfreq: Use OPP interface to handle the frequency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Sep 2017 08:09:22 +0000
From:   MyungJoo Ham <myungjoo.ham@...sung.com>
To:     Chanwoo Choi <cw00.choi@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>
CC:     "rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>,
        "chanwoo@...nel.org" <chanwoo@...nel.org>,
        Inki Dae <inki.dae@...sung.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: Re: [PATCH v2 0/8] PM / devfreq: Use OPP interface to handle
 the frequency

> Hi Myungjoo,
> 
> Could you please review this patchset?


I ignored your v2 patchset because of the follow-up message:

| Re: [PATCH v2 8/8] PM / devfreq: exynos-bus: Register cooling device
|
| Dear all,
|
| Please ignore this patch. It has some problem.
| I'll fix and resend this patch on v2.

I thought you'd send another series with [PATCH v3 x/8]...

(I've just noticed that [PATCH v2.1] was sent yesterday.
 Is the patchsetv2 ready with the replacement of 8th commit?)

Cheers,
MyungJoo

ps. you know I'm going to be away for a long vacation
 starting this week.
 I can't gurantee that I'll see all of the set before the vacation.

> 
> On 2017년 09월 21일 09:33, Chanwoo Choi wrote:
> > These patches makes the devfreq to use the OPP interface and clean-up codes.
> > - patch 1~5 are related to the OPP interfaces. 
> > - patch 6 removes the unneeded code.
> > - patch 7 clean-up for the governor name.
> > - patch 8 registers the cooling device for exynos-bus.
> > 
> > [Detaild Descripion]
> > The commit a76caf55e5b3 ("thermal: Add devfreq cooling") provides
> > the devfreq cooling device by using the OPP interface such as
> > dev_pm_opp_disable() and dev_pm_opp_enable(). It means that
> > the OPP interface is able to change the available status of the frequency.
> > 
> > Firstly, the existing devfreq doesn't use the OPP interface when showing
> > the minimum and maximum frequency through the following sysfs nodes:
> > It shows the wrong frequency value because min_freq/max_freq don't
> > consider the frequency status by handling OPP interface
> > (opp_dev_pm_opp_{disable|add}()). So, these patches fix this issue.
> > - /sys/class/devfreq/devfreqX/min_freq
> > - /sys/class/devfreq/devfreqX/max_freq
> > 
> > Second, the 'available_frequencies' should show the all supported frequencis
> > even if the specific frequency is not available. It doesn't matter whether
> > frequneyc is available or not. Because the role of 'available_frequencies'
> > shows the all frequencies. Also, these patches fix this issue.
> > - /sys/class/devfreq/devfreqX/available_frequencies
> > 
> > Third, update_devfreq() get the available next frequency by using
> > the devfreq_recommended_opp() in order to consider the disabled OPP.