linux-kernel - Re: [GIT PULL] x86-refcount fix for v4.14-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jKshVvuTyVycAbAYSVx5KU9nSBHUw+vmSc8p-2JdBhftw@mail.gmail.com>
Date:   Wed, 27 Sep 2017 13:47:44 +0200
From:   Kees Cook <keescook@...omium.org>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Mike Galbraith <efault@....de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [GIT PULL] x86-refcount fix for v4.14-rc3

On Wed, Sep 27, 2017 at 12:57 PM, Ingo Molnar <mingo@...nel.org> wrote:
>
> * Kees Cook <keescook@...omium.org> wrote:
>
>> Hi,
>>
>> Please pull this x86-refcount fix for v4.14-rc3. This restores the x86
>> fast-refcount protection after fixing a corner case that was found late
>> before the merge window opened. This was the only problem seen during
>> the protection's life in linux-next, so getting this into v4.14 is
>> highly desired.
>
> No, this is clearly v4.15 material.

Given the long bake time in linux-next (with only the one bug), and
that the fix was done weeks ago, why the delay?

>> Kees Cook (2):
>>       locking/refcounts, x86/asm: Use unique .text section for refcount exceptions
>>       locking/refcounts, x86/asm: Enable CONFIG_ARCH_HAS_REFCOUNT
>
> Do these commits differ from what you sent as patches on Sep 2?

They are the same, but now that we've reached -rc2, there's no longer
the fuzz against the linker script changes, so it seemed like a better
way to send them your way.

-Kees

-- 
Kees Cook
Pixel Security