linux-kernel - Re: [PATCH v9] ACPI / init: Invoke early ACPI initialization earlier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4eadcbc-fe58-2d2c-818d-34e2f545db16@cn.fujitsu.com>
Date:   Wed, 27 Sep 2017 09:41:49 +0800
From:   Dou Liyang <douly.fnst@...fujitsu.com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        "Zheng, Lv" <lv.zheng@...el.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-acpi@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, <x86@...nel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Will Deacon <will.deacon@....com>,
        <linux-arm-kernel@...ts.infradead.org>,
        Tony Luck <tony.luck@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        <linux-ia64@...r.kernel.org>, <yinghai@...nel.org>,
        <bhe@...hat.com>, <bp@...en8.de>, <fengguang.wu@...el.com>
Subject: Re: [PATCH v9] ACPI / init: Invoke early ACPI initialization earlier

Hi Rafael, Zheng,

Welcome any comments!

Now, our patches are in tip tree, they are based on this
independent patch, we hope it can be merged earlier than our
patches to avoid ACPI Error. we need your advice and confirmation.

Thanks,
	dou.

At 09/13/2017 05:17 PM, Dou Liyang wrote:
> Linux uses acpi_early_init() to put the ACPI table management into the
> late stage from the early stage. This two stages are different. the
> mapped ACPI tables in early stage is temporary and should be unmapped,
> but in late stage, it is permanent and don't need to be unmapped.
>
> Originally, mapping and parsing the DMAR table should be in the late stage.
> However, Initializing interrupt delivery mode earlier will move it into
> the early stage. This causes an ACPI error warning when Linux reallocates
> the ACPI root tables.
>
> Commit b064a8fa77df ("ACPI / init: Switch over platform to the ACPI mode
> later") splits the ACPI early initialization code into acpi_early_init()
> and acpi_subsystem_init(). This makes acpi_early_init() more independently
>
> So, invoke acpi_early_init() earlier before late_time_init(), Keep the DMAR
> be mapped and parsed in late stage like before.
>
> Reported-by: Xiaolong Ye <xiaolong.ye@...el.com>
> Signed-off-by: Dou Liyang <douly.fnst@...fujitsu.com>
> Cc: linux-acpi@...r.kernel.org
> Cc: Rafael J. Wysocki <rjw@...ysocki.net>
> Cc: Zheng, Lv <lv.zheng@...el.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: x86@...nel.org
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Will Deacon <will.deacon@....com>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: Fenghua Yu <fenghua.yu@...el.com>
> Cc: linux-ia64@...r.kernel.org
> Cc: yinghai@...nel.org
> Cc: bhe@...hat.com
> Cc: bp@...en8.de
> ---
>  init/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/init/main.c b/init/main.c
> index 0ee9c686..2fb98a4 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -664,12 +664,12 @@ asmlinkage __visible void __init start_kernel(void)
>  	debug_objects_mem_init();
>  	setup_per_cpu_pageset();
>  	numa_policy_init();
> +	acpi_early_init();
>  	if (late_time_init)
>  		late_time_init();
>  	calibrate_delay();
>  	pidmap_init();
>  	anon_vma_init();
> -	acpi_early_init();
>  #ifdef CONFIG_X86
>  	if (efi_enabled(EFI_RUNTIME_SERVICES))
>  		efi_enter_virtual_mode();
>