linux-kernel - Re: [Intel-gfx] [PATCH 05/14] i915: Use %pS printk format for direct addresses

Open Source and information security mailing list archives

Message-ID: <20170927122401.oqvdnaduzdk5tdwl@phenom.ffwll.local>
Date:   Wed, 27 Sep 2017 14:24:01 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Helge Deller <deller@....de>
Cc:     linux-kernel@...r.kernel.org, Petr Mladek <pmladek@...e.com>,
        David Airlie <airlied@...ux.ie>,
        intel-gfx@...ts.freedesktop.org,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [Intel-gfx] [PATCH 05/14] i915: Use %pS printk format for direct
 addresses

On Wed, Sep 06, 2017 at 10:27:52PM +0200, Helge Deller wrote:
> Use the %pS printk format for printing symbols from direct addresses.
> This is important for the ia64, ppc64 and parisc64 architectures, while on
> other architectures there is no difference between %pS and %pF.
> Fix it for consistency across the kernel.

i915.ko never runs on any of these, but if it helps with keeping things
consistent, why not.

Applied, thanks.
-Daniel

> 
> Signed-off-by: Helge Deller <deller@....de>
> Cc: Jani Nikula <jani.nikula@...ux.intel.com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: intel-gfx@...ts.freedesktop.org
> ---
>  drivers/gpu/drm/i915/intel_breadcrumbs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_breadcrumbs.c b/drivers/gpu/drm/i915/intel_breadcrumbs.c
> index 4e00e5c..29c62d4 100644
> --- a/drivers/gpu/drm/i915/intel_breadcrumbs.c
> +++ b/drivers/gpu/drm/i915/intel_breadcrumbs.c
> @@ -64,7 +64,7 @@ static unsigned long wait_timeout(void)
>  
>  static noinline void missed_breadcrumb(struct intel_engine_cs *engine)
>  {
> -	DRM_DEBUG_DRIVER("%s missed breadcrumb at %pF, irq posted? %s, current seqno=%x, last=%x\n",
> +	DRM_DEBUG_DRIVER("%s missed breadcrumb at %pS, irq posted? %s, current seqno=%x, last=%x\n",
>  			 engine->name, __builtin_return_address(0),
>  			 yesno(test_bit(ENGINE_IRQ_BREADCRUMB,
>  					&engine->irq_posted)),
> -- 
> 2.1.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives