linux-kernel - Re: unneeded internal declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <b4f6635f-99ca-126e-0ce2-8d57a8b77fe0@redhat.com>
Date:   Wed, 27 Sep 2017 14:50:27 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Avi Ghosh <aghosh@...hat.com>,
        Nick Desaulniers <nick.desaulniers@...il.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        josh@...htriplett.org
Cc:     avi@...hat.com, kay@...y.org, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: unneeded internal declaration

On 27/09/2017 14:39, Avi Ghosh wrote:
> Can someone remove me form this thread. I don’t know why I’m on it.

Because you are avi@...hat.com, which belonged to Avi Kivity before you.

In any case, no one can "remove you from this thread".  Everyone
involved would have to remember to remove you from each and every
message that is sent on this thread.  It's much simpler if you use the
"Ignore thread" or "Mute thread" functionality of your mail client.

Paolo

> On Mon, Sep 25, 2017 at 10:07 PM Nick Desaulniers
> <nick.desaulniers@...il.com <mailto:nick.desaulniers@...il.com>> wrote:
> 
>     today I noticed I was getting the warning:
> 
>     arch/x86/kvm/vmx.c:64:32: warning: variable 'vmx_cpu_id' is not needed
>     and will not be emitted [-Wunneeded-internal-declaration]
> 
>     seems like this was added in commit: e9bda3b3d0ce7 "KVM: VMX:
>     Auto-load on CPUs with VMX"
> 
>     seems like other call sites of the MODULE_DEVICE_TABLE typically get
>     added to an id_table of various driver structs.  Should that be the
>     case here, or would a `__unused` modifier be a way forward (if so,
>     please confirm, would be a good first bug for a friend)?
>