linux-kernel - Re: [PATCH] mm: kill kmemcheck again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170927150207.swmcarc4lqlklohr@dhcp22.suse.cz>
Date:   Wed, 27 Sep 2017 17:02:07 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     "Levin, Alexander (Sasha Levin)" <alexander.levin@...izon.com>
Cc:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH] mm: kill kmemcheck again

On Wed 27-09-17 11:27:40, Sasha Levin wrote:
> 2 Years ago I proposed to kill kmemcheck:
> 
> > As discussed on LSF/MM, kill kmemcheck.
> >
> > KASan is a replacement that is able to work without the limitation of
> > kmemcheck (single CPU, slow). KASan is already upstream.
> >
> > We are also not aware of any users of kmemcheck (or users who don't consider
> > KASan as a suitable replacement).
> 
> The only objection was that since KASAN wasn't supported by all GCC
> versions provided by distros at that time we should hold off for 2
> years, and try again.
> 
> Now that 2 years have passed, and all distros provide gcc that supports
> KASAN, kill kmemcheck again for the very same reasons.

This is just too large to review manually. How have you generated the
patch?

My compile test batery failed for i386 allyesconfig for some reason
which is not entirely clear to me (see attached).  I have applied on top
of dc972a67cc54585bd83ad811c4e9b6ab3dcd427e and that one compiles fine.

> Cc: Steven Rostedt (VMware) <rostedt@...dmis.org>
> Cc: David S. Miller <davem@...emloft.net>
> Signed-off-by: Sasha Levin <alexander.levin@...izon.com>

Anyway I fully support this removal. It is a lot of rarely used code and
KASAN is much more usable.
-- 
Michal Hocko
SUSE Labs

View attachment "i386_20170927_163226.log" of type "text/plain" (12978 bytes)