linux-kernel - Re: [PATCH] mtd: nand: atmel: fix buffer overflow in atmel_pmecc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ab0ab38-bdd1-0f9c-2fe9-0f006b90e498@microchip.com>
Date:   Wed, 27 Sep 2017 17:32:22 +0200
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Richard Genoud <richard.genoud@...il.com>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>
CC:     linux-mtd <linux-mtd@...ts.infradead.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: nand: atmel: fix buffer overflow in atmel_pmecc_user

On 27/09/2017 at 14:49, Richard Genoud wrote:
> When calculating the size needed by struct atmel_pmecc_user *user,
> the dmu and delta buffer sizes were forgotten.
> This lead to a memory corruption (especially with a large ecc_strength).
> 
> Link: http://lkml.kernel.org/r/1506503157.3016.5.camel@gmail.com
> Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver")
> Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>

Yes:
Reviewed-by: Nicolas Ferre <nicolas.ferre@...rochip.com>
Thanks Richard and Boris for this quick fix!

Regards,
  Nicolas

> Cc: stable@...r.kernel.org
> Reported-by: Richard Genoud <richard.genoud@...il.com>
> Pointed-at-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
> Signed-off-by: Richard Genoud <richard.genoud@...il.com>
> ---
>  drivers/mtd/nand/atmel/pmecc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c
> index 146af8218314..8268636675ef 100644
> --- a/drivers/mtd/nand/atmel/pmecc.c
> +++ b/drivers/mtd/nand/atmel/pmecc.c
> @@ -363,7 +363,7 @@ atmel_pmecc_create_user(struct atmel_pmecc *pmecc,
>  	size += (req->ecc.strength + 1) * sizeof(u16);
>  	/* Reserve space for mu, dmu and delta. */
>  	size = ALIGN(size, sizeof(s32));
> -	size += (req->ecc.strength + 1) * sizeof(s32);
> +	size += (req->ecc.strength + 1) * sizeof(s32) * 3;
>  
>  	user = kzalloc(size, GFP_KERNEL);
>  	if (!user)
> 


-- 
Nicolas Ferre