linux-kernel - RE: [PATCH] staging: unisys/visorbus: add __init/_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 27 Sep 2017 18:52:51 +0000
From:   "Kershner, David A" <David.Kershner@...sys.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     "Sell, Timothy C" <Timothy.Sell@...sys.com>,
        "Wadgaonkar, Sameer Laxmikant" <Sameer.Wadgaonkar@...sys.com>,
        "Binder, David Anthony" <David.Binder@...sys.com>,
        "Thompson, Bryan E." <bryan.thompson@...sys.com>,
        *S-Par-Maintainer <SParMaintainer@...sys.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] staging: unisys/visorbus: add __init/__exit annotations

> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@...db.de]
> Sent: Friday, September 15, 2017 3:23 PM
> To: Kershner, David A <David.Kershner@...sys.com>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>
> Cc: Arnd Bergmann <arnd@...db.de>; Sell, Timothy C
> <Timothy.Sell@...sys.com>; Wadgaonkar, Sameer Laxmikant
> <Sameer.Wadgaonkar@...sys.com>; Binder, David Anthony
> <David.Binder@...sys.com>; Thompson, Bryan E.
> <bryan.thompson@...sys.com>; *S-Par-Maintainer
> <SParMaintainer@...sys.com>; devel@...verdev.osuosl.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH] staging: unisys/visorbus: add __init/__exit annotations
> 
> gcc-4.6 causes a harmless warning about the init function:
> 
> WARNING: vmlinux.o(.text+0xed62c2): Section mismatch in reference from
> the function init_unisys() to the function
.init.text:visorutil_spar_detect()
> The function init_unisys() references
> the function __init visorutil_spar_detect().
> This is often because init_unisys lacks a __init
> annotation or the annotation of visorutil_spar_detect is wrong.
> 
> It appears that newer versions inline visorutil_spar_detect(),
> end up with an empty __init section. This marks the module
> entry points as __init and __exit respectively, which avoids
> the warning and slightly reduces the runtime code size.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: David Kershner <david.kershner@...sys.com>

Thanks,
David Kershner

> ---
>  drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
> b/drivers/staging/unisys/visorbus/visorchipset.c
> index 74cce4f1a7bd..27ecf6fb49fd 100644
> --- a/drivers/staging/unisys/visorbus/visorchipset.c
> +++ b/drivers/staging/unisys/visorbus/visorchipset.c
> @@ -1826,7 +1826,7 @@ static __init int visorutil_spar_detect(void)
>  	return 0;
>  }
> 
> -static int init_unisys(void)
> +static int __init init_unisys(void)
>  {
>  	int result;
> 
> @@ -1841,7 +1841,7 @@ static int init_unisys(void)
>  	return 0;
>  };
> 
> -static void exit_unisys(void)
> +static void __exit exit_unisys(void)
>  {
>  	acpi_bus_unregister_driver(&unisys_acpi_driver);
>  }
> --
> 2.9.0


Download attachment "smime.p7s" of type "application/pkcs7-signature" (7862 bytes)