linux-kernel - Re: [PATCH] ipmi: pr_err() strings should end with newlines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aeb135d8-a697-f09a-e38d-22104fb49817@acm.org>
Date:   Wed, 27 Sep 2017 15:35:19 -0500
From:   Corey Minyard <minyard@....org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, luto@...nel.org
Cc:     openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi: pr_err() strings should end with newlines

On 09/25/2017 02:49 AM, Arvind Yadav wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.

Thanks, it's queued for the next release.

-corey

> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>   drivers/char/ipmi/ipmi_dmi.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_dmi.c b/drivers/char/ipmi/ipmi_dmi.c
> index 2a84401..66dafcd 100644
> --- a/drivers/char/ipmi/ipmi_dmi.c
> +++ b/drivers/char/ipmi/ipmi_dmi.c
> @@ -71,13 +71,13 @@ static void __init dmi_add_platform_ipmi(unsigned long base_addr,
>   		size = 2;
>   		break;
>   	default:
> -		pr_err("ipmi:dmi: Invalid IPMI type: %d", type);
> +		pr_err("ipmi:dmi: Invalid IPMI type: %d\n", type);
>   		return;
>   	}
>   
>   	pdev = platform_device_alloc(name, ipmi_dmi_nr);
>   	if (!pdev) {
> -		pr_err("ipmi:dmi: Error allocation IPMI platform device");
> +		pr_err("ipmi:dmi: Error allocation IPMI platform device\n");
>   		return;
>   	}
>   	pdev->driver_override = override;
> @@ -239,7 +239,7 @@ static void __init dmi_decode_ipmi(const struct dmi_header *dm)
>   				offset = 16;
>   				break;
>   			default:
> -				pr_err("ipmi:dmi: Invalid offset: 0");
> +				pr_err("ipmi:dmi: Invalid offset: 0\n");
>   				return;
>   			}
>   		}