linux-kernel - Wrong -dirty suffix set by setlocalversion (was: BUG in git diff-index)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89d82c84-7a3b-9c4c-679e-a7a723669592@intel.com>
Date:   Wed, 27 Sep 2017 14:06:24 -0700
From:   Marc Herbert <Marc.Herbert@...el.com>
To:     Junio C Hamano <gitster@...ox.com>,
        Andy Lowry <andy.work@...owry.com>
Cc:     Jeff King <peff@...f.net>, git <git@...r.kernel.org>,
        Christian Kujau <lists@...dbynature.de>, josh@...htriplett.org,
        michael.w.mason@...el.com, linux-kernel@...r.kernel.org,
        linux-kbuild@...r.kernel.org
Subject: Wrong -dirty suffix set by setlocalversion (was: BUG in git
 diff-index)

+ linux-kbuild list which is not in the output of:
  ./scripts/get_maintainer.pl -f scripts/setlocalversion 
... but seems relevant anyway.

On 31/03/16 13:39, Junio C Hamano wrote:
> Andy Lowry <andy.work@...owry.com> writes:
> 
>> So I think now that the script should do "update-index --refresh"
>> followed by "diff-index --quiet HEAD". Sound correct?
> 
> Yes.  That has always been one of the kosher ways for any script to
> make sure that the files in the working tree that are tracked have
> not been modified relative to HEAD (assuming that the index matches
> HEAD).  

Too bad kernel/scripts/setlocalversion didn't get the memo:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cdf2bc632ebc9ef51
> scripts/setlocalversion on write-protected source tree (2013)
> I don't see how removing "git update-index" could do any harm.

This causes a spurious "-dirty" suffix when building from a directory copy
(as Mike learned the hard way)

[...]

https://public-inbox.org/git/1459432667.2124.2.camel@dwim.me