linux-kernel - Re: [PATCH] drm/omap: Fix error handling path in 'omap_dmm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f6eff5aa-a578-b63d-5552-42557f8f73cf@ti.com>
Date:   Thu, 28 Sep 2017 09:23:49 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        <airlied@...ux.ie>
CC:     <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] drm/omap: Fix error handling path in 'omap_dmm_probe()'


Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

On 24/09/17 09:01, Christophe JAILLET wrote:
> If we don't find a matching device node, we must free the memory allocated
> in 'omap_dmm' a few lines above.
> 
> Fixes: 7cb0d6c17b96 ("drm/omap: fix TILER on OMAP5")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> index 1dd3dafc59af..c60a85e82c6d 100644
> --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> @@ -638,7 +638,8 @@ static int omap_dmm_probe(struct platform_device *dev)
>  		match = of_match_node(dmm_of_match, dev->dev.of_node);
>  		if (!match) {
>  			dev_err(&dev->dev, "failed to find matching device node\n");
> -			return -ENODEV;
> +			ret = -ENODEV;
> +			goto fail;
>  		}
>  
>  		omap_dmm->plat_data = match->data;
> 

Thanks! I have picked this up.

 Tomi