linux-kernel - Re: [PATCH] dmaengine: pl330: fix descriptor allocation fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 28 Sep 2017 13:17:50 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Alexander Kochetkov <al.kochet@...il.com>
Cc:     Marek Szyprowski <m.szyprowski@...sung.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: pl330: fix descriptor allocation fail

On Tue, Sep 26, 2017 at 09:03:50PM +0300, Alexander Kochetkov wrote:
> Hello Vinod! Thanks for review!
> 
> > 26 сент. 2017 г., в 20:37, Vinod Koul <vinod.koul@...el.com> написал(а):
> > 
> > Tested-by please...
> 
> In order to test the patch the driver should be rebuild with NR_DEFAULT_DESC defined to 1
> and with some trace code included. Is it OK if I provide second patch I used for testing
> with trace showing how change work?
> 
> > one more wrapper why, we dont have any logic here!
> The idea was to keep rest of driver code intact. Ok, I’ll send v2 with no wrappers.
> 
> > right justifed please
> 
> 
> Some functions has two tabs on second line, some has alignment to beginning of
> argument declaration. How correct?
> 
> 1) or like this (two tabs)
> static int add_desc(struct list_head *pool, spinlock_t *lock,
>                 gfp_t flg, int count)
> 
> 2) Like this:
> static int add_desc(struct list_head *pool, spinlock_t *lock,
> 		               gfp_t flg, int count)

Second one with one more tab :)

See Section 2  Breaking long lines and strings in
Documentation/process/coding-style.rst

-- 
~Vinod