linux-kernel - Re: [PATCH v6 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 28 Sep 2017 11:10:41 +0300
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Leon Luo <leonl@...pardimaging.com>
Cc:     mchehab@...nel.org, robh+dt@...nel.org, mark.rutland@....com,
        hans.verkuil@...co.com, sakari.ailus@...ux.intel.com,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Sören Brinkmann <soren.brinkmann@...inx.com>
Subject: Re: [PATCH v6 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS
 sensor

Hi Leon,

On Wed, Sep 27, 2017 at 11:48:21PM -0700, Leon Luo wrote:
> Hi Sakari,
> 
> Thanks for your comments.
> 
> Regarding imx274_tp_regs[], the first value is the test pattern mode, which
> will be updated according to the input value before writing the register.
> So it can't be a const.

In that case you'll need to explicitly write that register; this is
specific to a device whereas the static variable is the same for all
devices.

> 
> I will use __v4l2_ctrl_s_ctrl instead of v4l2_ctrl_s_ctrl to keep the
> lock/unlock mutex clean. I am traveling right now, will test it and send a
> new patch this weekend.

Ack.

-- 
Sakari Ailus
e-mail: sakari.ailus@....fi