linux-kernel - Re: [PATCH for-next 8/9] RDMA/hns: Remove unused struct members in hns-abi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170928090203.GS2297@mtr-leonro.local>
Date:   Thu, 28 Sep 2017 12:02:03 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     "Wei Hu (Xavier)" <xavier.huwei@...wei.com>
Cc:     dledford@...hat.com, linux-rdma@...r.kernel.org,
        lijun_nudt@....com, oulijun@...wei.com, charles.chenxin@...wei.com,
        liuyixian@...wei.com, xushaobo2@...wei.com,
        zhangxiping3@...wei.com, xavier.huwei@....com, linuxarm@...wei.com,
        linux-kernel@...r.kernel.org, shaobohsu@....com
Subject: Re: [PATCH for-next 8/9] RDMA/hns: Remove unused struct members in
 hns-abi.h

On Thu, Sep 28, 2017 at 12:57:33PM +0800, Wei Hu (Xavier) wrote:
> From: Lijun Ou <oulijun@...wei.com>
>
> This patch mainly deletes some unused struct members for
> hns_roce_ib_create_qp in order to match libhns, because
> the num of struct members of hns_roce_ib_create_qp must
> be the same with hns_roce_create_qp in libhns.
>
> Signed-off-by: Lijun Ou <oulijun@...wei.com>
> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@...wei.com>
> Signed-off-by: Shaobo Xu <xushaobo2@...wei.com>
> ---
>  include/uapi/rdma/hns-abi.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/include/uapi/rdma/hns-abi.h b/include/uapi/rdma/hns-abi.h
> index 5d74019..79251b6 100644
> --- a/include/uapi/rdma/hns-abi.h
> +++ b/include/uapi/rdma/hns-abi.h
> @@ -41,10 +41,8 @@ struct hns_roce_ib_create_cq {
>
>  struct hns_roce_ib_create_qp {
>  	__u64	buf_addr;
> -	__u64   db_addr;
>  	__u8    log_sq_bb_count;
>  	__u8    log_sq_stride;
> -	__u8    sq_no_prefetch;
>  	__u8    reserved[5];
>  };

It is classical UAPI breakage which kernel tries to avoid.

In RDMA, we do allow rename of fields from reserved to something, but
don't allow binary layout change.

NAK to this change.

Thanks

>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)