linux-kernel - Re: [PATCH] Use RX_BUF_SIZE to set size of RX buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170928100451.GL6739@hermes.home>
Date:   Thu, 28 Sep 2017 11:04:51 +0100
From:   Martyn Welch <martyn.welch@...labora.co.uk>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Use RX_BUF_SIZE to set size of RX buffer

On Thu, Sep 28, 2017 at 12:00:19PM +0200, Uwe Kleine-König wrote:
> On Thu, Sep 28, 2017 at 10:52:15AM +0100, Martyn Welch wrote:
> > The imx serial driver uses PAGE_SIZE when allocating rx_buf, but then
> > uses RX_BUF_SIZE (which is currently defined as PAGE_SIZE) to describe
> > the length of the buffer when initialising the scatter gather list.
> > 
> > In order to ensure that this stays consistent, use RX_BUF_SIZE in both
> > locations.
> 
> Missing SoB Line

Doh! v2 on way...

> 
> > ---
> >  drivers/tty/serial/imx.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> > index fe368a4..bc2f2a2f 100644
> > --- a/drivers/tty/serial/imx.c
> > +++ b/drivers/tty/serial/imx.c
> > @@ -1165,7 +1165,7 @@ static int imx_uart_dma_init(struct imx_port *sport)
> >  		goto err;
> >  	}
> >  
> > -	sport->rx_buf = kzalloc(PAGE_SIZE, GFP_KERNEL);
> > +	sport->rx_buf = kzalloc(RX_BUF_SIZE, GFP_KERNEL);
> >  	if (!sport->rx_buf) {
> >  		ret = -ENOMEM;
> >  		goto err;
> Acked-by: Uwe Kleine-König <u.kleine-könig@...gtronix.de>
> 
> 
> -- 
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |