linux-kernel - Re: [PATCH v4 3/3] MAINTAINERS: xen, kvm: track pvclock-abi.h changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c8fc087a-13bb-a96c-6de2-d89d1ec61fba@redhat.com>
Date:   Thu, 28 Sep 2017 12:56:58 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        Joao Martins <joao.m.martins@...cle.com>
Cc:     linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org,
        kvm@...r.kernel.org, Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>,
        Radim Krcmar <rkrcmar@...hat.com>,
        Andy Lutomirski <luto@...capital.net>
Subject: Re: [PATCH v4 3/3] MAINTAINERS: xen, kvm: track pvclock-abi.h changes

On 27/09/2017 18:06, Konrad Rzeszutek Wilk wrote:
> On Wed, Sep 27, 2017 at 02:46:23PM +0100, Joao Martins wrote:
>> This file defines an ABI shared between guest and hypervisor(s)
>> (KVM, Xen) and as such there should be an correspondent entry in
>> MAINTAINERS file. Notice that there's already a text notice at the
>> top of the header file, hence this commit simply enforces it more
>> explicitly and have both peers noticed when such changes happen.
>>
>> Signed-off-by: Joao Martins <joao.m.martins@...cle.com>
>> Acked-by: Juergen Gross <jgross@...e.com>
> 
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>

Acked-by: Paolo Bonzini <pbonzini@...hat.com>

>> ---
>> In the end, I choose the originally posted because this is so far the
>> only ABI shared between Xen/KVM. Therefore whenever we have more things
>> shared it would deserve its own place in MAINTAINERS file. If the
>> thinking is wrong, I can switch to the alternative with a
>> "PARAVIRT ABIS" section.
>>
>> Changes since v1:
>>  * Add Juergen Gross Acked-by.
>> ---
>>  MAINTAINERS | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 6671f375f7fc..a4834c3c377a 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -7603,6 +7603,7 @@ S:	Supported
>>  F:	arch/x86/kvm/
>>  F:	arch/x86/include/uapi/asm/kvm*
>>  F:	arch/x86/include/asm/kvm*
>> +F:	arch/x86/include/asm/pvclock-abi.h
>>  F:	arch/x86/kernel/kvm.c
>>  F:	arch/x86/kernel/kvmclock.c
>>  
>> @@ -14718,6 +14719,7 @@ F:	arch/x86/xen/
>>  F:	drivers/*/xen-*front.c
>>  F:	drivers/xen/
>>  F:	arch/x86/include/asm/xen/
>> +F:	arch/x86/include/asm/pvclock-abi.h
>>  F:	include/xen/
>>  F:	include/uapi/xen/
>>  F:	Documentation/ABI/stable/sysfs-hypervisor-xen
>> -- 
>> 2.11.0
>>