linux-kernel - Re: sched: serial port lockdep warning when offlining CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170928113607.GB30818@jagdpanzerIV.localdomain>
Date:   Thu, 28 Sep 2017 20:36:07 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Sasha Levin <levinsasha928@...il.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...e.hu>,
        "linux-kernel@...r.kernel.org List" <linux-kernel@...r.kernel.org>,
        alexander.levin@...izon.com, pmladek@...e.com,
        sergey.senozhatsky@...il.com, rostedt@...dmis.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Subject: Re: sched: serial port lockdep warning when offlining CPUs

On (09/28/17 19:30), Sergey Senozhatsky wrote:
>  lib/ratelimit.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/ratelimit.c b/lib/ratelimit.c
> index 08f8043cac61..bddc55834c2e 100644
> --- a/lib/ratelimit.c
> +++ b/lib/ratelimit.c
> @@ -48,7 +48,8 @@ int ___ratelimit(struct ratelimit_state *rs, const char *func)
>  	if (time_is_before_jiffies(rs->begin + rs->interval)) {
>  		if (rs->missed) {
>  			if (!(rs->flags & RATELIMIT_MSG_ON_RELEASE)) {
> -				pr_warn("%s: %d callbacks suppressed\n", func, rs->missed);
> +				printk_deferred(KERN_WARN "%s: %d callbacks suppressed\n",

oops...				s/KERN_WARN/KERN_WARNING/

sorry about that.

> +						func, rs->missed);
>  				rs->missed = 0;
>  			}
>  		}


---
 lib/ratelimit.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/ratelimit.c b/lib/ratelimit.c
index 08f8043cac61..d01f47135239 100644
--- a/lib/ratelimit.c
+++ b/lib/ratelimit.c
@@ -48,7 +48,9 @@ int ___ratelimit(struct ratelimit_state *rs, const char *func)
 	if (time_is_before_jiffies(rs->begin + rs->interval)) {
 		if (rs->missed) {
 			if (!(rs->flags & RATELIMIT_MSG_ON_RELEASE)) {
-				pr_warn("%s: %d callbacks suppressed\n", func, rs->missed);
+				printk_deferred(KERN_WARNING
+						"%s: %d callbacks suppressed\n",
+						func, rs->missed);
 				rs->missed = 0;
 			}
 		}
-- 
2.14.2