linux-kernel - RE: linux-4.14-rc2/drivers/acpi/acpica/utmath.c: 2 * suspicious expression ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1AE640813FDE7649BE1B193DEA596E886CF6DECD@SHSMSX101.ccr.corp.intel.com>
Date:   Thu, 28 Sep 2017 02:58:40 +0000
From:   "Zheng, Lv" <lv.zheng@...el.com>
To:     David Binderman <dcb314@...mail.com>,
        "Moore, Robert" <robert.moore@...el.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "devel@...ica.org" <devel@...ica.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: linux-4.14-rc2/drivers/acpi/acpica/utmath.c: 2 * suspicious
 expression ?

Hi, David

Not a fancy way, but just a bit clearing.
OK, style is changed here:
https://github.com/acpica/acpica/pull/321
And bug is recorded here:
https://bugs.acpica.org/show_bug.cgi?id=1422

Thanks for the report.

Best regards
Lv

> From: David Binderman [mailto:dcb314@...mail.com]
> Subject: linux-4.14-rc2/drivers/acpi/acpica/utmath.c: 2 * suspicious expression ?
> 
> Hello there,
> 
> [linux-4.14-rc2/drivers/acpi/acpica/utmath.c:137] -> [linux-4.14-rc2/drivers/acpi/acpica/utmath.c:137]:
> (style) Same expression on both sides of '^='.
> [linux-4.14-rc2/drivers/acpi/acpica/utmath.c:174] -> [linux-4.14-rc2/drivers/acpi/acpica/utmath.c:174]:
> (style) Same expression on both sides of '^='.
> 
>     operand_ovl.part.lo ^= operand_ovl.part.lo;
> 
> Is this just a fancy way to zero the field or should something more clever
> be happening ?
> 
> Regards
> 
> David Binderman
>