[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <95186e1f-98dc-1a9b-15a9-03911fd2012f@ti.com>
Date: Wed, 27 Sep 2017 22:10:40 -0500
From: Nishanth Menon <nm@...com>
To: Atul Garg <agarg@...san.com>, Shawn Lin <shawn.lin@...k-chips.com>
CC: <rk@...com>, <adrian.hunter@...el.com>, <kishon@...com>,
<linux-kernel@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
<ulf.hansson@...aro.org>, <nsekhar@...com>
Subject: Re: [PATCH] mmc:host:sdhci-pci: Addition of Arasan PCI controller
with integrated phy.
On 09/27/2017 02:27 PM, Atul Garg wrote:
> On Sep 26, 2017 8:55 PM, "Shawn Lin" <shawn.lin@...k-chips.com
> <mailto:shawn.lin@...k-chips.com>> wrote:
> On 2017/9/27 2:59, Atul Garg wrote:
[...]
> ---
> drivers/mmc/host/sdhci-pci-core.c | 372
> ++++++++++++++++++++++++++++++++++++++
>
>
> Fundamentally maybe you need a sdhci-pci-arasan.c
>
> And the arasan PHY isn't new here as sdhci-of-arasan already added
> arasan PHY support for eMMC 5.1, but just with different register
> layout and content. So could you also use generic PHY framework?
>
>
> Thanks. We are doing two things adding support for Arasan PCI SDHC and
> PHY specific code to it integrated via a window in same PCI address
> space (extended).
>
> If we correctly understand, you are suggesting to take the PHY code
> out as a PHY driver module similar to phy/rockchip/ and use those
> functions from phy framework within the sdhci-pci-core?
yes, it might allow some reuse possibly as well.
--
Regards,
Nishanth Menon
PS: please switch to plain text.
Powered by blists - more mailing lists