linux-kernel - Re: [PATCH for-next 2/9] RDMA/hns: Factor out the code for checking sdb status into a new function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170928135014.GY2297@mtr-leonro.local>
Date:   Thu, 28 Sep 2017 16:50:14 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     "Wei Hu (Xavier)" <xavier.huwei@...wei.com>
Cc:     dledford@...hat.com, linux-rdma@...r.kernel.org,
        lijun_nudt@....com, oulijun@...wei.com, charles.chenxin@...wei.com,
        liuyixian@...wei.com, xushaobo2@...wei.com,
        zhangxiping3@...wei.com, xavier.huwei@....com, linuxarm@...wei.com,
        linux-kernel@...r.kernel.org, shaobohsu@....com
Subject: Re: [PATCH for-next 2/9] RDMA/hns: Factor out the code for checking
 sdb status into a new function

On Thu, Sep 28, 2017 at 12:57:27PM +0800, Wei Hu (Xavier) wrote:
> From: Lijun Ou <oulijun@...wei.com>
>
> It mainly places the lines for checking send doorbell status
> into a special functions. As a result, we can directly call it in
> check_qp_db_process_status function and keep consistent indenting
> style.
>
> It fixes: 5f110ac4bed8 ("IB/hns: Fix for checkpatch.pl comment style)

You forgot " at the end of the line, and there is need to put fixes
(should be Fixes) in the line before Signed-off-by.

> The warning from static checker:
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c:3562 check_qp_db_process_status()
> warn: inconsistent indenting
>
> Signed-off-by: Lijun Ou <oulijun@...wei.com>
> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@...wei.com>
> Signed-off-by: Shaobo Xu <xushaobo2@...wei.com>
> ---
>  drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 95 ++++++++++++++++--------------
>  1 file changed, 51 insertions(+), 44 deletions(-)
>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)