linux-kernel - Re: [PATCH v2 1/3] ARM: dts: sun8i: Add basic dtsi file for Allwinner R40

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170928151103.ov3o5pn5h7inzzan@flea>
Date:   Thu, 28 Sep 2017 17:11:03 +0200
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Icenowy Zheng <icenowy@...c.io>
Cc:     Chen-Yu Tsai <wens@...e.org>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-sunxi@...glegroups.com
Subject: Re: [PATCH v2 1/3] ARM: dts: sun8i: Add basic dtsi file for
 Allwinner R40

Hi,

On Thu, Sep 28, 2017 at 09:25:41AM +0000, Icenowy Zheng wrote:
> +		/*
> +		 * The max-frequency properties in all MMC controller nodes
> +		 * are conservative values proven to work on Banana Pi M2
> +		 * Ultra (the first community available R40 board).
> +		 * As the board doesn't wire MMC3 out, the property is not
> +		 * set in MMC3.
> +		 * TODO: measure the accurate max frequency of the controllers.
> +		 */
> +		mmc0: mmc@...f000 {
> +			compatible = "allwinner,sun8i-r40-mmc",
> +				     "allwinner,sun50i-a64-mmc";
> +			reg = <0x01c0f000 0x1000>;
> +			clocks = <&ccu CLK_BUS_MMC0>, <&ccu CLK_MMC0>;
> +			clock-names = "ahb", "mmc";
> +			resets = <&ccu RST_BUS_MMC0>;
> +			reset-names = "ahb";
> +			pinctrl-0 = <&mmc0_pins>;
> +			pinctrl-names = "default";
> +			interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
> +			max-frequency = <25000000>;
> +			status = "disabled";
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +		};

Sorry if it wasn't really clear, but my point was more than you should
just drop the max-frequency property

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)