linux-kernel - Re: [PATCH][ipmi-next] ipmi: remove redundant initialization of bmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9f2f6048-64d0-ec82-43b1-f101d5a77f8c@acm.org>
Date:   Thu, 28 Sep 2017 12:31:23 -0500
From:   Corey Minyard <minyard@....org>
To:     Colin King <colin.king@...onical.com>,
        openipmi-developer@...ts.sourceforge.net
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][ipmi-next] ipmi: remove redundant initialization of bmc

On 09/28/2017 08:22 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> The pointer bmc is being initialized and this initialized value is
> never being read, so this is assignment redundant and can be removed.
> Cleans up clang warning:
>
> warning: Value stored to 'bmc' during its initialization is never read

yes, obviously unneeded.  Queued.

Thanks,

-corey

> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>   drivers/char/ipmi/ipmi_msghandler.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index c29d46bef6b3..9de189db2cc3 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -2941,7 +2941,7 @@ static int __ipmi_bmc_register(ipmi_smi_t intf,
>   			       bool guid_set, guid_t *guid, int intf_num)
>   {
>   	int               rv;
> -	struct bmc_device *bmc = intf->bmc;
> +	struct bmc_device *bmc;
>   	struct bmc_device *old_bmc;
>   
>   	/*