lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20170928190614.v5jgejvgdlyxbxrh@dell> Date: Thu, 28 Sep 2017 20:06:14 +0100 From: Lee Jones <lee.jones@...aro.org> To: Maxime Ripard <maxime.ripard@...e-electrons.com> Cc: Quentin Schulz <quentin.schulz@...e-electrons.com>, linus.walleij@...aro.org, robh+dt@...nel.org, mark.rutland@....com, wens@...e.org, linux@...linux.org.uk, linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-sunxi@...glegroups.com, thomas.petazzoni@...e-electrons.com Subject: Re: [PATCH v2 07/10] mfd: axp20x: add pinctrl cell for AXP813 On Tue, 26 Sep 2017, Maxime Ripard wrote: > On Tue, Sep 26, 2017 at 12:17:17PM +0000, Quentin Schulz wrote: > > As pinctrl and GPIO driver now supports AXP813, add a cell for it. > > > > Signed-off-by: Quentin Schulz <quentin.schulz@...e-electrons.com> > > --- > > drivers/mfd/axp20x.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > > index 336de66..a457528 100644 > > --- a/drivers/mfd/axp20x.c > > +++ b/drivers/mfd/axp20x.c > > @@ -876,6 +876,9 @@ static struct mfd_cell axp813_cells[] = { > > .name = "axp221-pek", > > .num_resources = ARRAY_SIZE(axp803_pek_resources), > > .resources = axp803_pek_resources, > > + }, { > > + .name = "axp20x-gpio", > > + .of_compatible = "x-powers,axp813-pctl", > > This was probably introduced in the previous driver, but why are you > using the pctl suffix? Can't we just use the GPIO one to remain > consistent with the previous users and the datasheet? Right. Pinctrl is a Linuxisum. GPIO sounds more appropriate. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists