linux-kernel - Re: [RFC PATCH 1/2] arm64: mm: Use READ_ONCE/WRITE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOZdJXXwyFYOAUM5nXC670yqfniiR7GKLrKFqm9-rLjoS_oXTg@mail.gmail.com>
Date:   Thu, 28 Sep 2017 14:18:05 -0500
From:   Timur Tabi <timur@...eaurora.org>
To:     Will Deacon <will.deacon@....com>
Cc:     Peter Zijlstra <peterz@...radead.org>, paulmck@...ux.vnet.ibm.com,
        kirill.shutemov@...ux.intel.com,
        lkml <linux-kernel@...r.kernel.org>,
        Yury Norov <ynorov@...iumnetworks.com>,
        rruigrok@...eaurora.org, linux-arch@...r.kernel.org,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        Catalin Marinas <catalin.marinas@....com>
Subject: Re: [RFC PATCH 1/2] arm64: mm: Use READ_ONCE/WRITE_ONCE when
 accessing page tables

On Wed, Sep 27, 2017 at 10:49 AM, Will Deacon <will.deacon@....com> wrote:
> This patch consistently uses these macros in the arch
> code, as well as explicitly namespacing pointers to page table entries
> from the entries themselves by using adopting a 'p' suffix for the former
> (as is sometimes used elsewhere in the kernel source).

Would you consider splitting up this patch into two, where the second
patch makes all the cosmetic changes?  That would make the "meatier"
patch easier to back-port and review.