linux-kernel - Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <EE09EDA8-B6E9-4BEB-882C-C5435EDA8E41@intel.com>
Date:   Thu, 28 Sep 2017 22:28:04 +0000
From:   "Rustad, Mark D" <mark.d.rustad@...el.com>
To:     Grant Grundler <grundler@...omium.org>
CC:     Oliver Neukum <oneukum@...e.com>,
        Doug Anderson <dianders@...omium.org>,
        "David S . Miller" <davem@...emloft.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Hayes Wang <hayeswang@...ltek.com>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-usb <linux-usb@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id


> On Sep 27, 2017, at 9:39 AM, Grant Grundler <grundler@...omium.org> wrote:
> 
> On Wed, Sep 27, 2017 at 12:15 AM, Oliver Neukum <oneukum@...e.com> wrote:
>> Am Dienstag, den 26.09.2017, 08:19 -0700 schrieb Doug Anderson:
>>> 
>>> I know that for at least some of the adapters in the CDC Ethernet
>>> blacklist it was claimed that the CDC Ethernet support in the adapter
>>> was kinda broken anyway so the blacklist made sense.  ...but for the
>>> Linksys Gigabit adapter the CDC Ethernet driver seems to work OK, it's
>>> just not quite as full featured / efficient as the R8152 driver.
>>> 
>>> Is that not a concern?  I guess you could tell people in this
>>> situation that they simply need to enable the R8152 driver to get
>>> continued support for their Ethernet adapter?
>> 
>> Hi,
>> 
>> yes, it is a valid concern. An #ifdef will be needed.
> 
> Good idea - I will post V3 shortly.
> 
> I'm assuming you mean to add #ifdef CONFIG_USB_RTL8152 around the
> blacklist entry in cdc_ether driver.

Shouldn't that be an #if IS_ENABLED(...) test, since that seems to be the proper way to check configured drivers.

--
Mark Rustad, Networking Division, Intel Corporation


Download attachment "signature.asc" of type "application/pgp-signature" (842 bytes)