linux-kernel - Re: [RFC PATCH v2 3/7] sched/idle: Add poll before enter real idle path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2c4fc9d1-3e57-19ae-7b68-7bbeeaed3ccf@gmail.com>
Date:   Fri, 29 Sep 2017 18:39:33 +0800
From:   Quan Xu <quan.xu0@...il.com>
To:     Borislav Petkov <bp@...en8.de>,
        Yang Zhang <yang.zhang.wz@...il.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        wanpeng.li@...mail.com, mst@...hat.com, pbonzini@...hat.com,
        tglx@...utronix.de, rkrcmar@...hat.com, dmatlack@...gle.com,
        agraf@...e.de, peterz@...radead.org, linux-doc@...r.kernel.org,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Kyle Huey <me@...ehuey.com>, Andy Lutomirski <luto@...nel.org>,
        Len Brown <len.brown@...el.com>
Subject: Re: [RFC PATCH v2 3/7] sched/idle: Add poll before enter real idle
 path



On 2017/9/1 14:49, Quan Xu wrote:
> on 2017/8/29 22:39, Borislav Petkov wrote:
>> On Tue, Aug 29, 2017 at 11:46:37AM +0000, Yang Zhang wrote:
>>> Add poll in do_idle. For UP VM, if there are running task, it will not
>>> goes into idle path, so we only enable poll in SMP VM.
>>>
>>> Signed-off-by: Yang Zhang <yang.zhang.wz@...il.com>
>>> Signed-off-by: Quan Xu <quan.xu0@...il.com>
>>> Cc: Thomas Gleixner <tglx@...utronix.de>
>>> Cc: Ingo Molnar <mingo@...hat.com>
>>> Cc: "H. Peter Anvin" <hpa@...or.com>
>>> Cc: x86@...nel.org
>>> Cc: Peter Zijlstra <peterz@...radead.org>
>>> Cc: Borislav Petkov <bp@...en8.de>
>>> Cc: Kyle Huey <me@...ehuey.com>
>>> Cc: Andy Lutomirski <luto@...nel.org>
>>> Cc: Len Brown <len.brown@...el.com>
>>> Cc: linux-kernel@...r.kernel.org
>>> ---
>>>   arch/x86/kernel/process.c | 7 +++++++
>>>   kernel/sched/idle.c       | 2 ++
>>>   2 files changed, 9 insertions(+)
>>>
>>> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
>>> index 3ca1980..def4113 100644
>>> --- a/arch/x86/kernel/process.c
>>> +++ b/arch/x86/kernel/process.c
>>> @@ -332,6 +332,13 @@ void arch_cpu_idle(void)
>>>       x86_idle();
>>>   }
>>>   +#if defined(CONFIG_SMP) && defined(CONFIG_PARAVIRT)
>>> +void arch_cpu_idle_poll(void)
>>> +{
>>> +    paravirt_idle_poll();
>>> +}
>>> +#endif
>> So this will get called on any system which has CONFIG_PARAVIRT enabled
>> *even* if they're not running any guests.
>>
>> Huh?
      Borislav,
      think twice, it is better to run ander an IF condition, to make 
sure they are running any guests.

       Quan
> Borislav ,
>    yes, this will get called on any system which has CONFIG_PARAVIRT 
> enabled.
>
>    but if they are not running any guests,  the callback is 
> paravirt_nop() ,
>    IIUC which is as similar as the other paravirt_*, such as 
> paravirt_pgd_free()..
>
>  - Quan