linux-kernel - Re: [PATCH][rdma-next] RDMA/hns: make various function static, fixes warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 29 Sep 2017 11:27:15 -0400
From:   Doug Ledford <dledford@...hat.com>
To:     Colin King <colin.king@...onical.com>,
        Lijun Ou <oulijun@...wei.com>,
        Wei Hu <xavier.huwei@...wei.com>,
        Sean Hefty <sean.hefty@...el.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>,
        linux-rdma@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][rdma-next] RDMA/hns: make various function static,
 fixes warnings

On Fri, 2017-09-29 at 14:16 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The functions hns_roce_table_mhop_get, hns_roce_table_mhop_put,
> hns_roce_cleanup_mhop_hem_table,  hns_roce_v1_post_mbox,
> hns_roce_cmq_setup_basic_desc, hns_roce_cmq_send,
> hns_roce_cmq_query_hw_info are all local to the source and do
> not need to be in global scope, so make them static.
> 
> Cleans up sparse warnings:
> symbol 'hns_roce_table_mhop_get' was not declared. Should it be
> static?
> symbol 'hns_roce_table_mhop_put' was not declared. Should it be
> static?
> symbol 'hns_roce_cleanup_mhop_hem_table' was not declared. Should it
> be
> static?
> symbol 'hns_roce_v1_post_mbox' was not declared. Should it be static?
> symbol 'hns_roce_cmq_setup_basic_desc' was not declared. Should it be
> static?
> symbol 'hns_roce_cmq_send' was not declared. Should it be static?
> symbol 'hns_roce_cmq_query_hw_info' was not declared. Should it be
> static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Thanks, applied.

-- 
Doug Ledford <dledford@...hat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD