linux-kernel - [PATCH v7 0/2] tracing: Add trace events for preemption and irq disable/enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20170929212144.24039-1-joelaf@google.com>
Date:   Fri, 29 Sep 2017 14:21:42 -0700
From:   Joel Fernandes <joelaf@...gle.com>
To:     linux-kernel@...r.kernel.org
Cc:     kernel-team@...roid.com, Joel Fernandes <joelaf@...gle.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Peter Zilstra <peterz@...radead.org>
Subject: [PATCH v7 0/2] tracing: Add trace events for preemption and irq disable/enable

These patches add trace events support for preempt and irq disable/enable
events.

Here's an example of how Android's systrace will be using it to show atomic
sections as a gantt chart: http://imgur.com/download/TZplEVp
Other advantages of this initial work could be rewriting of preemptirqs off
tracer to use trace events, and replacing kprobes with tracepoint hooks for
these events in BPF samples (see samples/bpf/lathist_kern.c).

Changes since v6:
1. Drop the stop_critical_timings changes - previous patch was generating the
preempt_enable/disable events. Instead since we already have cpuidle trace
events, we can just rely on those for now to understand how much time was spent
in idle. A future patch could do something smarter.

2. Drop the per-cpu variable usage from trace_preempt_enable/disable.
The trace_preempt_enable/disable calls don't nest, so there's no need
to protect it with a per-cpu variable.

3. trace_irq_enable/disable on the other hand are called in this way,
so I added some comments about why per-cpu variable is needed.

Joel Fernandes (2):
  tracing: Prepare to add preempt and irq trace events
  tracing: Add support for preempt and irq enable/disable events

 include/linux/ftrace.h            |   3 +-
 include/trace/events/preemptirq.h |  66 ++++++++++++++++++
 kernel/trace/Kconfig              |   9 +++
 kernel/trace/Makefile             |   1 +
 kernel/trace/trace_irqsoff.c      | 139 +++++++++++++++++++++++++++++++-------
 5 files changed, 191 insertions(+), 27 deletions(-)
 create mode 100644 include/trace/events/preemptirq.h

Links to earlier series:
v6: https://lkml.org/lkml/2017/9/21/789
v5: https://lkml.org/lkml/2017/9/12/507
v4: https://lkml.org/lkml/2017/9/6/724
v3: https://lkml.org/lkml/2017/9/3/15

Cc: kernel-team@...roid.com
Cc: Steven Rostedt <rostedt@...dmis.org>
Cc: Peter Zilstra <peterz@...radead.org>
-- 
2.14.2.822.g60be5d43e6-goog