linux-kernel - Re: [PATCH 2/2] nvme: use device_add_disk_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170929230006.GQ8463@localhost.localdomain>
Date:   Fri, 29 Sep 2017 17:00:07 -0600
From:   Keith Busch <keith.busch@...el.com>
To:     Martin Wilck <mwilck@...e.com>
Cc:     Jens Axboe <axboe@...nel.dk>, Christoph Hellwig <hch@....de>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        Hannes Reinecke <hare@...e.de>, linux-nvme@...ts.infradead.org,
        Martin Wilck <mwilck@...e.de>
Subject: Re: [PATCH 2/2] nvme: use device_add_disk_with_groups()

On Thu, Sep 28, 2017 at 09:36:37PM +0200, Martin Wilck wrote:
> By using device_add_disk_with_groups(), we can avoid the race
> condition with udev rule processing, because no udev event will
> be triggered before all attributes are available.
> 
> Signed-off-by: Martin Wilck <mwilck@...e.com>

Looks good.

Reviewed-by: Keith Busch <keith.busch@...el.com>