linux-kernel - Re: [PATCH 04/12] Input: atmel_mxt_ts - use managed devm_device_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170929234601.GK14362@dtor-ws>
Date:   Fri, 29 Sep 2017 16:46:01 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Andi Shyti <andi@...zian.org>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andi Shyti <andi.shyti@...sung.com>,
        Nick Dyer <nick@...anahar.org>
Subject: Re: [PATCH 04/12] Input: atmel_mxt_ts - use managed
 devm_device_add_group

On Sat, Sep 30, 2017 at 05:38:31AM +0900, Andi Shyti wrote:
> Commit 57b8ff070f98 ("driver core: add devm_device_add_group()
> and friends") has added the the managed version for creating
> sysfs group files.
> 
> Use devm_device_add_group instead of sysfs_create_group.
> 
> CC: Nick Dyer <nick@...anahar.org>
> Signed-off-by: Andi Shyti <andi@...zian.org>
> ---
>  drivers/input/touchscreen/atmel_mxt_ts.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
> index 7659bc48f1db..e5968f136f08 100644
> --- a/drivers/input/touchscreen/atmel_mxt_ts.c
> +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
> @@ -3170,7 +3170,7 @@ static int mxt_probe(struct i2c_client *client, const struct i2c_device_id *id)
>  	if (error)
>  		return error;
>  
> -	error = sysfs_create_group(&client->dev.kobj, &mxt_attr_group);
> +	error = devm_device_add_group(&client->dev, &mxt_attr_group);
>  	if (error) {
>  		dev_err(&client->dev, "Failure %d creating sysfs group\n",
>  			error);
> @@ -3190,7 +3190,6 @@ static int mxt_remove(struct i2c_client *client)
>  	struct mxt_data *data = i2c_get_clientdata(client);
>  
>  	disable_irq(data->irq);
> -	sysfs_remove_group(&client->dev.kobj, &mxt_attr_group);

Wrong ordering.

>  	mxt_free_input_device(data);
>  	mxt_free_object_table(data);
>  
> -- 
> 2.14.2
> 

-- 
Dmitry