linux-kernel - Re: [PATCH REBASED 3/6] s390: Add __down_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 30 Sep 2017 11:20:02 +0200
From:   Heiko Carstens <heiko.carstens@...ibm.com>
To:     Kirill Tkhai <ktkhai@...tuozzo.com>
Cc:     linux-ia64@...r.kernel.org, avagin@...tuozzo.com,
        peterz@...radead.org, hpa@...or.com, gorcunov@...tuozzo.com,
        linux-arch@...r.kernel.org, linux-s390@...r.kernel.org,
        x86@...nel.org, mingo@...hat.com, mattst88@...il.com,
        fenghua.yu@...el.com, arnd@...db.de, ink@...assic.park.msu.ru,
        tglx@...utronix.de, rth@...ddle.net, tony.luck@...el.com,
        linux-kernel@...r.kernel.org, linux-alpha@...r.kernel.org,
        schwidefsky@...ibm.com, davem@...emloft.net, rientjes@...gle.com,
        viro@...iv.linux.org.uk
Subject: Re: [PATCH REBASED 3/6] s390: Add __down_read_killable()

On Fri, Sep 29, 2017 at 07:06:18PM +0300, Kirill Tkhai wrote:
> Similar to __down_write_killable(), and read killable primitive.
> 
> Signed-off-by: Kirill Tkhai <ktkhai@...tuozzo.com>
> ---
>  arch/s390/include/asm/rwsem.h |   18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/s390/include/asm/rwsem.h b/arch/s390/include/asm/rwsem.h

FWIW, while looking into this patch I realized that we never optimized our
rwsem primitives to make use of new atomic instructions.

The generic rwsem header file however does, since it uses atomic ops which
we did optimize. Even when compiling for old machines the generic version
generates better code. Therefore I will remove the 15 years old s390
implementation and switch to the generic version instead.

The same might be true for alpha and ia64...