linux-kernel - Re: [PATCH] tpm: fix duplicate inline declaration specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH7mPvhP7i=6AThzfzP1W4wXuywcjj+bn8Pu0kaBAVg7rx0fZw@mail.gmail.com>
Date:   Fri, 29 Sep 2017 17:46:41 -0700
From:   Nick Desaulniers <nick.desaulniers@...il.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:     Ruben Roy <rubenroy2005@...il.com>,
        Peter Huewe <peterhuewe@....de>,
        Marcel Selhorst <tpmdd@...horst.net>,
        Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
        tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
        trivial@...nel.org
Subject: Re: [PATCH] tpm: fix duplicate inline declaration specifier

Thanks! This fixes a warning I was seeing with Clang:

drivers/char/tpm/tpm.h:560:15: warning: duplicate 'inline' declaration
specifier [-Wduplicate-decl-specifier]

On Fri, Sep 29, 2017 at 10:17 AM, Jarkko Sakkinen
<jarkko.sakkinen@...ux.intel.com> wrote:
> On Tue, Sep 26, 2017 at 01:58:57PM +0000, Ruben Roy wrote:
>> This commit fixes the duplicate inline declaration specifier in
>> tpm2_rc_value which caused a warning
>>
>> Signed-off-by: Ruben Roy <rubenroy2005@...il.com>
>> ---
>>  drivers/char/tpm/tpm.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
>> index 04fbff2..f4d0272 100644
>> --- a/drivers/char/tpm/tpm.h
>> +++ b/drivers/char/tpm/tpm.h
>> @@ -550,7 +550,7 @@ static inline void tpm_add_ppi(struct tpm_chip *chip)
>>  }
>>  #endif
>>
>> -static inline inline u32 tpm2_rc_value(u32 rc)
>> +static inline u32 tpm2_rc_value(u32 rc)
>>  {
>>       return (rc & BIT(7)) ? rc & 0xff : rc;
>>  }
>> --
>> 1.8.3.1
>>
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
>
> /Jarkko