linux-kernel - Re: [PATCH] HSI: hsi_char: pr_err() strings should end with newlines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171001151316.mklrwif4tg5nx5ok@earth>
Date:   Sun, 1 Oct 2017 17:13:16 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HSI: hsi_char: pr_err() strings should end with newlines

Hi,

On Tue, Sep 26, 2017 at 11:46:14AM +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Thanks, queued.

-- Sebastian

> ---
>  drivers/hsi/clients/hsi_char.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hsi/clients/hsi_char.c b/drivers/hsi/clients/hsi_char.c
> index 57f70c2..cf9c2a3 100644
> --- a/drivers/hsi/clients/hsi_char.c
> +++ b/drivers/hsi/clients/hsi_char.c
> @@ -773,13 +773,13 @@ static int __init hsc_init(void)
>  
>  	if ((max_data_size < 4) || (max_data_size > 0x10000) ||
>  		(max_data_size & (max_data_size - 1))) {
> -		pr_err("Invalid max read/write data size");
> +		pr_err("Invalid max read/write data size\n");
>  		return -EINVAL;
>  	}
>  
>  	ret = hsi_register_client_driver(&hsc_driver);
>  	if (ret) {
> -		pr_err("Error while registering HSI/SSI driver %d", ret);
> +		pr_err("Error while registering HSI/SSI driver %d\n", ret);
>  		return ret;
>  	}
>  
> -- 
> 1.9.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)