linux-kernel - Re: [PATCH v3 03/13] perf report: create real callchain entries for inlined frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1506879637.2274.5.camel@perches.com>
Date:   Sun, 01 Oct 2017 10:40:37 -0700
From:   Joe Perches <joe@...ches.com>
To:     Milian Wolff <milian.wolff@...b.com>, Jiri Olsa <jolsa@...hat.com>
Cc:     acme@...nel.org, Linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH v3 03/13] perf report: create real callchain entries for
 inlined frames

On Sun, 2017-10-01 at 14:37 +0200, Milian Wolff wrote:
> On Dienstag, 19. September 2017 14:27:11 CEST Jiri Olsa wrote:
[]
> > nit, think we prefer the /* */ comment style
> 
> I'll fix this, but note that there are more places outside this patch series 
> where this style has crept in. Some of them also from past patches of mine - 
> sorry for that.

I think c99 comments are fine.
So did Linus Torvalds.

http://lkml.iu.edu/hypermail/linux/kernel/1607.1/00627.html

> I looks to me as if the checkpatch.pl should catch this, but it doesn't for me 
> which is odd. Does anyone know what I need to do to enable the C99_COMMENTS 
> check?

Modify checkpatch

my $allow_c99_comments = 1;

change the 1 to 0

Add a runtime option if you want.