linux-kernel - Re: [PATCH] nvme: make config_item_type __ro_after

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOH+1jFW5b2C05kP9FHHT_529kCy4cJ2z6QF9XyUHYhMixXPfQ@mail.gmail.com>
Date:   Mon, 2 Oct 2017 13:48:38 +0530
From:   Bhumika Goyal <bhumirks@...il.com>
To:     Julia Lawall <julia.lawall@...6.fr>, hch@....de,
        Kees Cook <keescook@...omium.org>, sagi@...mberg.me,
        linux-nvme@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:     Bhumika Goyal <bhumirks@...il.com>
Subject: Re: [PATCH] nvme: make config_item_type __ro_after_init

On Mon, Oct 2, 2017 at 12:44 AM, Bhumika Goyal <bhumirks@...il.com> wrote:
> Make these __ro_after_init as they are only stored as a reference in the
> ci_type field of a config_item structure during the init phase in the
> function config_group_init_type_name. None of the fields of these
> structures are modified after the init phase, so they can be
> __ro_after_init.
>
> Structures found using Coccinelle and changes done by hand.
>

Hello all,

This patch should be dropped as the structures can also be made const
instead of __ro_after_init. I will send a patch making them const.

Thanks,
Bhumika

> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
> ---
>  drivers/nvme/target/configfs.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c
> index b6aeb1d..075d9b5 100644
> --- a/drivers/nvme/target/configfs.c
> +++ b/drivers/nvme/target/configfs.c
> @@ -767,7 +767,7 @@ static struct config_group *nvmet_subsys_make(struct config_group *group,
>         .make_group             = nvmet_subsys_make,
>  };
>
> -static struct config_item_type nvmet_subsystems_type = {
> +static struct config_item_type nvmet_subsystems_type __ro_after_init = {
>         .ct_group_ops           = &nvmet_subsystems_group_ops,
>         .ct_owner               = THIS_MODULE,
>  };
> @@ -921,7 +921,7 @@ static struct config_group *nvmet_ports_make(struct config_group *group,
>         .make_group             = nvmet_ports_make,
>  };
>
> -static struct config_item_type nvmet_ports_type = {
> +static struct config_item_type nvmet_ports_type __ro_after_init = {
>         .ct_group_ops           = &nvmet_ports_group_ops,
>         .ct_owner               = THIS_MODULE,
>  };
> @@ -963,7 +963,7 @@ static struct config_group *nvmet_hosts_make_group(struct config_group *group,
>         .make_group             = nvmet_hosts_make_group,
>  };
>
> -static struct config_item_type nvmet_hosts_type = {
> +static struct config_item_type nvmet_hosts_type __ro_after_init = {
>         .ct_group_ops           = &nvmet_hosts_group_ops,
>         .ct_owner               = THIS_MODULE,
>  };
> --
> 1.9.1
>