linux-kernel - Re: [PATCH][sdhci-next] mmc: sdhci-omap: make three functions static, fixes warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 2 Oct 2017 10:29:50 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][sdhci-next] mmc: sdhci-omap: make three functions static,
 fixes warnings

On 26 September 2017 at 16:55, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> The functions sdhci_omap_set_ios, sdhci_omap_set_power and
> sdhci_omap_get_min_clock are local to the source and do not need
> to be in global scope, so make them static.
>
> Cleans up sparse warnings:
> symbol 'sdhci_omap_set_ios' was not declared. Should it be static?
> symbol 'sdhci_omap_set_power' was not declared. Should it be static?
> symbol 'sdhci_omap_get_min_clock' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci-omap.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
> index 5ddae39816b7..628bfe9a3d17 100644
> --- a/drivers/mmc/host/sdhci-omap.c
> +++ b/drivers/mmc/host/sdhci-omap.c
> @@ -262,7 +262,7 @@ static void sdhci_omap_set_bus_mode(struct sdhci_omap_host *omap_host,
>         omap_host->bus_mode = mode;
>  }
>
> -void sdhci_omap_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> +static void sdhci_omap_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>  {
>         struct sdhci_host *host = mmc_priv(mmc);
>         struct sdhci_pltfm_host *pltfm_host;
> @@ -323,7 +323,7 @@ static void sdhci_omap_set_clock(struct sdhci_host *host, unsigned int clock)
>         sdhci_omap_start_clock(omap_host);
>  }
>
> -void sdhci_omap_set_power(struct sdhci_host *host, unsigned char mode,
> +static void sdhci_omap_set_power(struct sdhci_host *host, unsigned char mode,
>                           unsigned short vdd)
>  {
>         struct mmc_host *mmc = host->mmc;
> @@ -344,7 +344,7 @@ static int sdhci_omap_enable_dma(struct sdhci_host *host)
>         return 0;
>  }
>
> -unsigned int sdhci_omap_get_min_clock(struct sdhci_host *host)
> +static unsigned int sdhci_omap_get_min_clock(struct sdhci_host *host)
>  {
>         struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>
> --
> 2.14.1
>