[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <1506933302.25065.3.camel@au1.ibm.com>
Date: Mon, 02 Oct 2017 10:35:02 +0200
From: Benjamin Herrenschmidt <benh@....ibm.com>
To: Stewart Smith <stewart@...ux.vnet.ibm.com>,
Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>,
mpe@...erman.id.au
Cc: ego@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
paulus@...ba.org, linuxppc-dev@...ts.ozlabs.org,
akshay.adiga@...ux.vnet.ibm.com
Subject: Re: [PATCH] powernv: Add OCC driver to mmap sensor area
On Mon, 2017-10-02 at 14:14 +1100, Stewart Smith wrote:
> Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com> writes:
> > This driver provides interface to mmap the OCC sensor area
> > to userspace to parse and read OCC inband sensors.
>
> Why?
>
> Is this for debug? If so, the existing exports interface should be used.
>
> If there's actual sensors, we already have two ways of exposing sensors
> to Linux: the OPAL_SENSOR API and the IMC API.
>
> Why this method and not use the existing ones?
More than that, a sensor should be exposed to userspace via hwmon, not
some random direct userspace map.
Ben.
Powered by blists - more mailing lists