linux-kernel - Re: [PATCH] firmware: tegra: add BPMP debugfs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e1e20e48-11a1-9b57-01a8-8eacef878571@nvidia.com>
Date:   Mon, 2 Oct 2017 11:36:23 +0300
From:   Timo Alho <talho@...dia.com>
To:     Jonathan Hunter <jonathanh@...dia.com>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] firmware: tegra: add BPMP debugfs support



On 29.09.2017 17:58, Jonathan Hunter wrote:
>>>> +static int bpmp_populate_dir(struct tegra_bpmp *bpmp, struct seqbuf
>>>> *seqbuf,
>>>> +                 struct dentry *parent, uint32_t depth)
>>>
>>> Do we need to use uint32_t here?
>>>
>>>> +{
>>>> +    int err;
>>>> +    uint32_t d, t;
>>>
>>> And here?
>>
>> It's part of the BPMP ABI that the data passed is 32 bit unsigned
>> integer. I wanted to emphasise that with the choice of integer type. Or
>> did you mean why I did not use u32?
> 
> Yes why not just u32?
> 

No other reason than just a personal bias to use standard C99 integer 
types. The downstream driver was using a mix of both so wanted to 
standardize to just one.