linux-kernel - Re: [PATCH] thunderbolt: make tb_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171002092825.GP4630@lahna.fi.intel.com>
Date:   Mon, 2 Oct 2017 12:28:25 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     julia.lawall@...6.fr, andreas.noever@...il.com,
        michael.jamet@...el.com, yehezkel.bernat@...el.com,
        linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] thunderbolt: make tb_domain_type const

On Sat, Sep 30, 2017 at 10:07:12PM +0530, Bhumika Goyal wrote:
> Make this const as it is only stored in the const field of a device
> structure. Make the declaration in header const too.
> 
> Structure found using Coccinelle and changes done by hand.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

This looks good. However, I'm currently doing some shuffling in
drivers/thunderbolt/tb.h to get Thunderbolt services supported which
makes this patch not to apply cleanly anymore:

https://lkml.org/lkml/2017/9/25/225

I wonder if you could rebase your patch on top of that?

Also please Cc Greg as well.