linux-kernel - Re: [PATCH v1 1/2] ASoC: codecs: msm8916-wcd-analog: move pm8916_wcd_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <06a1ca9b-f1aa-944e-0202-36a9c5af121b@linaro.org>
Date:   Mon, 2 Oct 2017 10:57:52 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Damien Riegel <damien.riegel@...oirfairelinux.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, kernel@...oirfairelinux.com
Subject: Re: [PATCH v1 1/2] ASoC: codecs: msm8916-wcd-analog: move
 pm8916_wcd_setup_mbhc


Thanks for the patch,

On 29/09/17 18:42, Damien Riegel wrote:
> In preparation of a fix for the initial detection of headset,
> pm8916_wcd_setup_mbhc is moved to be defined after
> pm8916_mbhc_configure_bias instead of before.
> 
> Signed-off-by: Damien Riegel <damien.riegel@...oirfairelinux.com>
> ---
>   sound/soc/codecs/msm8916-wcd-analog.c | 88 +++++++++++++++++------------------
>   1 file changed, 44 insertions(+), 44 deletions(-)
> 
I would suggest you to move this changes to second patch.

thanks,
srini

> diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c
> index f562f2d86907..9f08d998a79b 100644
> --- a/sound/soc/codecs/msm8916-wcd-analog.c
> +++ b/sound/soc/codecs/msm8916-wcd-analog.c
> @@ -443,50 +443,6 @@ static int pm8916_wcd_analog_enable_micbias_int1(struct
>   						     wcd->micbias1_cap_mode);
>   }