linux-kernel - Re: [Part2 PATCH v4 01/29] Documentation/virtual/kvm: Add AMD Secure Encrypted Virtualization (SEV)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171002132123.eebx2ituzucvbqx2@pd.tnic>
Date:   Mon, 2 Oct 2017 15:21:23 +0200
From:   Borislav Petkov <bp@...e.de>
To:     Brijesh Singh <brijesh.singh@....com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Jonathan Corbet <corbet@....net>,
        Tom Lendacky <thomas.lendacky@....com>, x86@...nel.org
Subject: Re: [Part2 PATCH v4 01/29] Documentation/virtual/kvm: Add AMD Secure
 Encrypted Virtualization (SEV)

On Mon, Oct 02, 2017 at 06:52:01AM -0500, Brijesh Singh wrote:
> Thank you for the patch. One of feedback in RFC patches was to put the
> command id and their definitions in amd-memory-encryption.txt hence I
> was trying to follow that recommendation. Most of ioctls I have seen in
> api.txt are either common or architecture specific. These commands are
> vendor specific and I was not sure if they belong to api.txt. I am okay
> with moving the definition to api.txt in next patch and we can see if
> kvm folks have any objections.

So api.txt has them all and this way you can grep them easily. Much
better than spreading stuff around.

But looking at it again, you have the actual ioctls
KVM_MEMORY_ENCRYPT_OP, KVM_MEMORY_ENCRYPT_{UN,}REGISTER_REGION
which are API so you could keep only those in api.txt but
add a sentence there saying that the commands are defined in
Documentation/virtual/kvm/amd-memory-encryption.txt

> The series does not implement the migration commands yet hence I took it
> off.

Ok.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--