linux-kernel - Re: [PATCH] writeback: remove unused parameter from balance_dirty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAeU0aPZ8BGSyrQeua=tUfme38frM-GxtmHrirveS0XdcnzWww@mail.gmail.com>
Date:   Mon, 2 Oct 2017 10:20:37 -0700
From:   Tahsin Erdogan <tahsin@...gle.com>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, Jan Kara <jack@...e.cz>,
        Johannes Weiner <hannes@...xchg.org>,
        Vladimir Davydov <vdavydov.dev@...il.com>,
        Jeff Layton <jlayton@...hat.com>,
        Matthew Wilcox <mawilcox@...rosoft.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        "Theodore Ts'o" <tytso@....edu>,
        Nikolay Borisov <nborisov@...e.com>, linux-mm@...ck.org,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] writeback: remove unused parameter from balance_dirty_pages()

On Mon, Oct 2, 2017 at 12:56 AM, Michal Hocko <mhocko@...nel.org> wrote:
> balance_dirty_pages_ratelimited doesn't really need mapping as well. All
> it needs is the inode and we already have it in callers. So would it
> make sense to refactor a bit further and make its argument an inode?

My only concern is that, balance_dirty_pages_ratelimited() is an
exported function so changing its signature could potentially break
some drivers?