linux-kernel - Re: [PATCH 0/5] lightnvm: pblk: audit mempool usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171002175851.GA6874@hercules.tuxera.com>
Date:   Mon, 2 Oct 2017 20:58:52 +0300
From:   Rakesh Pandit <rakesh@...era.com>
To:     Javier González <jg@...htnvm.io>
CC:     <axboe@...com>, <linux-block@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Javier González <javier@...xlabs.com>
Subject: Re: [PATCH 0/5] lightnvm: pblk: audit mempool usage

On Thu, Sep 14, 2017 at 12:33:42PM +0200, Javier González wrote:
> As suggested by Jens [1], I audited all mempools on pblk.
> 
> This patche series (i) fixes bad mempool allocations that did not
> guarantee forward progress and downsizes the sizes of some overused
> mempools, (ii) removes unnecessary checks, and (iii) eliminates some
> mempools that where introduced in early versions of pblk.

All claims made above seem to be addressed in patches correctly to me.

I also did some functional testing of pblk after reviewing.

Feel free to use tag for all patches in this series even though I am
not aware of some aspects of subsystem yet. This series doesn't seem
to touch those.

Reviewed-by: Rakesh Pandit <rakesh@...era.com>

> 
> [1] https://patchwork.kernel.org/patch/9940973/
> 
> Javier González (5):
>   lightnvm: pblk: fix min size for page mempool
>   lightnvm: pblk: simplify work_queue mempool
>   lightnvm: pblk: decouple read/erase mempools
>   lightnvm: pblk: do not use a mempool for line bitmaps
>   lightnvm: pblk: remove checks on mempool alloc.
> 
>  drivers/lightnvm/pblk-core.c     | 61 ++++++++++----------------
>  drivers/lightnvm/pblk-gc.c       | 32 +++++++-------
>  drivers/lightnvm/pblk-init.c     | 94 +++++++++++++++++-----------------------
>  drivers/lightnvm/pblk-read.c     | 10 +----
>  drivers/lightnvm/pblk-recovery.c | 37 ++++------------
>  drivers/lightnvm/pblk-write.c    | 32 ++++----------
>  drivers/lightnvm/pblk.h          | 21 +++++----
>  7 files changed, 106 insertions(+), 181 deletions(-)
> 
> -- 
> 2.7.4
>