linux-kernel - Re: [PATCH] input: synaptics-rmi4: make array rmi_f54_report_type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171002221852.GA12530@roeck-us.net>
Date:   Mon, 2 Oct 2017 15:18:52 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Colin King <colin.king@...onical.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Andrew Duggan <aduggan@...aptics.com>,
        linux-input@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: synaptics-rmi4: make array
 rmi_f54_report_type_names static

On Mon, Oct 02, 2017 at 11:05:25PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The array rmi_f54_report_type_names is local to the source and does
> not need to be in global scope, so make it static. Also make the array
> const char * const
> 
> Cleans up sparse warning:
> symbol 'rmi_f54_report_type_names' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/input/rmi4/rmi_f54.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c
> index f5206e2c767e..70f6310f1d15 100644
> --- a/drivers/input/rmi4/rmi_f54.c
> +++ b/drivers/input/rmi4/rmi_f54.c
> @@ -73,7 +73,7 @@ enum rmi_f54_report_type {
>  	F54_MAX_REPORT_TYPE,
>  };
>  
> -const char *rmi_f54_report_type_names[] = {
> +static const char * const rmi_f54_report_type_names[] = {
>  	[F54_REPORT_NONE]		= "Unknown",
>  	[F54_8BIT_IMAGE]		= "Normalized 8-Bit Image",
>  	[F54_16BIT_IMAGE]		= "Normalized 16-Bit Image",
> -- 
> 2.14.1
>