linux-kernel - Re: [PATCH v2 0/5] Simplify panel bridge cleanup

Open Source and information security mailing list archives

Message-ID: <20171003080602.srzra6yxni3nt2mj@phenom.ffwll.local>
Date:   Tue, 3 Oct 2017 10:06:02 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Benjamin Gaignard <benjamin.gaignard@...aro.org>
Cc:     architt@...eaurora.org, a.hajda@...sung.com,
        Laurent.pinchart@...asonboard.com, airlied@...ux.ie,
        daniel.vetter@...el.com, jani.nikula@...ux.intel.com,
        seanpaul@...omium.org, yannick.fertre@...com,
        philippe.cornu@...com, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2 0/5] Simplify panel bridge cleanup

On Mon, Oct 02, 2017 at 11:32:30AM +0200, Benjamin Gaignard wrote:
> The goal of this series is to simplify driver code when they need to clean up
> a previously allocated panel bridge.
> Few drivers have "is_panel_bridge" flag to be able to distinguish a
> drm_panel_bridge from "simple" drm_bridge.
> To remove this flag I propose to
> - let drm_panel_bridge_remove() check if the bridge provided in parameter is
>   really a drm_panel_bridge.
> - add drm_of_panel_bridge_remove() to remove a bridge given DT port and
>   endpoint
> Finally that allow to remove drm_bridge structure and "is_panel_bridge" flag
> from stm driver internal structure.
> 
> version 2:
> - does the same for vc4 and dw-mipi-dsi

Sweet. Ack on the entire series from my side. Since you have commit rights
I'd wait a bit more for feedback from driver maintainers, then push the
entire pile.

Cheers, Daniel

> 
> Benjamin Gaignard (5):
>   drm/bridge: make drm_panel_bridge_remove more robust
>   drm/drm_of: add drm_of_panel_bridge_remove function
>   drm/stm: ltdc: remove bridge from driver internal structure
>   drm/vc4: remove bridge from driver internal structure
>   drm/bridge/synopsys: dsi :remove is_panel_bridge
> 
>  drivers/gpu/drm/bridge/panel.c                | 10 +++++++-
>  drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c |  5 +---
>  drivers/gpu/drm/drm_of.c                      | 33 +++++++++++++++++++++++++++
>  drivers/gpu/drm/stm/ltdc.c                    | 16 ++++---------
>  drivers/gpu/drm/stm/ltdc.h                    |  2 --
>  drivers/gpu/drm/vc4/vc4_dpi.c                 | 17 +++++---------
>  include/drm/drm_of.h                          |  8 +++++++
>  7 files changed, 62 insertions(+), 29 deletions(-)
> 
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives