linux-kernel - Re: [BUGFIX PATCH] kprobes/x86: Remove IRQ disabling from jprobe handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171003093344.feh7gqa4aimsjwqv@gmail.com>
Date:   Tue, 3 Oct 2017 11:33:44 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     mingo@...hat.com, x86@...nel.org,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ananth N Mavinakayanahalli <ananth@...ux.vnet.ibm.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H . Peter Anvin" <hpa@...or.com>,
        "Paul E . McKenney" <paulmck@...ux.vnet.ibm.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Alexei Starovoitov <ast@...com>
Subject: Re: [BUGFIX PATCH] kprobes/x86: Remove IRQ disabling from jprobe
 handlers


* Masami Hiramatsu <mhiramat@...nel.org> wrote:

> Jprobe actually doesn't need to disable IRQs while calling
> handlers, because Documentation/kprobes.txt says:
> 
> -----
>  Probe handlers are run with preemption disabled.  Depending on the
>  architecture and optimization state, handlers may also run with
>  interrupts disabled (e.g., kretprobe handlers and optimized kprobe
>  handlers run without interrupt disabled on x86/x86-64).
> -----
> 
> So let's remove IRQ disabling from jprobes too.
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>
> ---
>  arch/x86/kernel/kprobes/core.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c
> index b48e0efd668e..bd36f3c33cd0 100644
> --- a/arch/x86/kernel/kprobes/core.c
> +++ b/arch/x86/kernel/kprobes/core.c
> @@ -1099,8 +1099,6 @@ int setjmp_pre_handler(struct kprobe *p, struct pt_regs *regs)
>  	 * raw stack chunk with redzones:
>  	 */
>  	__memcpy(kcb->jprobes_stack, (kprobe_opcode_t *)addr, MIN_STACK_SIZE(addr));
> -	regs->flags &= ~X86_EFLAGS_IF;
> -	trace_hardirqs_off();
>  	regs->ip = (unsigned long)(jp->entry);
>  
>  	/*

Could you please also do a patch that disables jprobes permanently, in preparation 
of eventually removing them later?

Thanks,

	Ingo