linux-kernel - [PATCH 0/2] minor fd cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue,  3 Oct 2017 12:58:13 +0200
From:   Mateusz Guzik <mguzik@...hat.com>
To:     Eric Dumazet <edumazet@...gle.com>,
        Al Viro <viro@...iv.linux.org.uk>
Cc:     mszeredi@...hat.com, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH 0/2] minor fd cleanup

The first patch is a super minor nit and  I'm fine with it being ignored.

Second patch is imho of actual value.

fd_install has an avoidable requirement to be called in a sleepable context.
It matters e.g. in rhel7 to where the patch was recently backported and the
new requirement could not be enforced.

I don't see any benefits from sleeping over locking and not sleeping makes
the function slightly nicer.

Mateusz Guzik (2):
  vfs: stop clearing close on exec when closing a fd
  vfs: grab the lock instead of blocking in __fd_install during resizing

 Documentation/filesystems/porting |  4 ----
 fs/file.c                         | 12 +++++++-----
 2 files changed, 7 insertions(+), 9 deletions(-)

-- 
1.8.3.1