linux-kernel - Re: [PATCH V2] firmware: tegra: add BPMP debugfs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d614ffff-880f-aa2e-ee23-17edef78c3c8@nvidia.com>
Date:   Tue, 3 Oct 2017 14:21:56 +0300
From:   Timo Alho <talho@...dia.com>
To:     Jonathan Hunter <jonathanh@...dia.com>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>
CC:     "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] firmware: tegra: add BPMP debugfs support


Jon, thanks for reviewing

On 03.10.2017 13:55, Jonathan Hunter wrote:
>> +static int create_debugfs_mirror(struct tegra_bpmp *bpmp, void *buf,
>> +				 size_t bufsize, struct dentry *root)
>> +{
>> +	struct seqbuf seqbuf;
>> +	int err;
>> +
>> +	bpmp->debugfs_mirror = debugfs_create_dir("debug", root);
>> +	if (!bpmp->debugfs_mirror)
>> +		return -ENOMEM;
> 
> Is this extra level needed? Do you plan to have other sub-directories
> under the main bpmp directory?

Yes, the downstream driver has few files under main directory (e.g. 
'ping' to check that firmware is alive, or 'tag' to read the firmware 
version).

BR,
Timo