linux-kernel - Re: [PATCH -v2 13/18] sched/fair: Propagate an effective runnable_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d710e98-2ab5-e181-4c9d-eef4e86f9bf0@arm.com>
Date:   Tue, 3 Oct 2017 13:26:39 +0100
From:   Dietmar Eggemann <dietmar.eggemann@....com>
To:     Peter Zijlstra <peterz@...radead.org>, mingo@...nel.org,
        linux-kernel@...r.kernel.org, tj@...nel.org, josef@...icpanda.com
Cc:     torvalds@...ux-foundation.org, vincent.guittot@...aro.org,
        efault@....de, pjt@...gle.com, clm@...com,
        morten.rasmussen@....com, bsegall@...gle.com, yuyang.du@...el.com
Subject: Re: [PATCH -v2 13/18] sched/fair: Propagate an effective
 runnable_load_avg

On 01/09/17 14:21, Peter Zijlstra wrote:

[...]

> @@ -3169,8 +3198,8 @@ ___update_load_sum(u64 now, int cpu, str
>  	 * this happens during idle_balance() which calls
>  	 * update_blocked_averages()
>  	 */

another nit-pick:

s/weight/load in comment above.

> -	if (!weight)
> -		running = 0;
> +	if (!load)
> +		runnable = running = 0;

[...]